Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BasicSwap FakeRun Typo #10274

Merged
merged 5 commits into from
Jun 14, 2023
Merged

Fix BasicSwap FakeRun Typo #10274

merged 5 commits into from
Jun 14, 2023
+44 −1

Conversation

evmckinney9
Copy link
Contributor

Summary

This is a repeat of #10149. This change is fixing a minor typo, where a variable was referenced instead of a method.

Details and comments

I initially made changes directly on the main branch of my forked repository, and opened a PR from this branch. Instead, I should have first created a new branch from main, made my changes on this new branch, and then opened the PR from the new branch. This error led to conflicts with the upstream main branch, requiring me to reset and force push on main, which closed the original PR.

As far as I can tell, opening a new PR is the best practice for fixing this mistake.

@evmckinney9 evmckinney9 requested a review from a team as a code owner June 14, 2023 03:33
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Jun 14, 2023
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

jakelishman
jakelishman approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks!

@jakelishman jakelishman added stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: Bugfix Include in the "Fixed" section of the changelog labels Jun 14, 2023
@jakelishman jakelishman added this to the 0.24.2 milestone Jun 14, 2023
@jakelishman jakelishman added this pull request to the merge queue Jun 14, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5262772438

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.05%) to 85.953%
Files with Coverage Reduction New Missed Lines %
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 1 90.39%
crates/qasm2/src/lex.rs 2 90.89%
qiskit/extensions/quantum_initializer/squ.py 2 80.0%
Totals Coverage Status
Change from base Build 5256241220: 0.05%
Covered Lines: 71333
Relevant Lines: 82991
💛 - Coveralls

Merged via the queue into Qiskit:main with commit 7df290b Jun 14, 2023
mergify bot pushed a commit that referenced this pull request Jun 14, 2023
@evmckinney9 @mergify
Fix BasicSwap FakeRun Typo (#10274)
2ebd549 
* fix typo, issue #10147

* create basicswap fake_run test

* release note for #10149 fix

* ensure fake_run modifes layout prop, not the circuit logic

* black formatting, test_basic_swap

(cherry picked from commit 7df290b)
@mergify mergify bot mentioned this pull request Jun 14, 2023
Merged
jakelishman pushed a commit that referenced this pull request Jun 14, 2023
@mergify @evmckinney9
Fix BasicSwap FakeRun Typo (#10274) (#10278)
9f18b91 
* fix typo, issue #10147

* create basicswap fake_run test

* release note for #10149 fix

* ensure fake_run modifes layout prop, not the circuit logic

* black formatting, test_basic_swap

(cherry picked from commit 7df290b)

Co-authored-by: Evan McKinney <47376937+evmckinney9@users.noreply.github.com>
@evmckinney9 evmckinney9 deleted the fakerun-typo branch June 14, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelishman jakelishman jakelishman approved these changes

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
Contributor Monitoring
Status: Done
Milestone
0.24.2
Development

Successfully merging this pull request may close these issues.
4 participants
@evmckinney9 @qiskit-bot @coveralls @jakelishman